change unconditional x86-64-v4 reliance to the former x86-64-v2 reliance #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a fix that closes #14 (removing the unconditional enabling of avx512 features)
It should be noted during my cursory audit, I found this crate appears to hard baseline on x86-64-v2 (with sse4.1 being silently asserted), and there might also be hard baselines on neon+aes with aarch64
This violates typical expectations (that code will compile against target baselines and only enable features that have a positive is_X_feature_detected call) so either compile errors should be inserted if not compiling against those baselines (ala simd_json) or new polyfills/checks should be inserted for software implementation