cleaning up code and organzie

Author: shesaave

action.yml

@@ -40,7 +40,6 @@ inputs:
   force-new-deployment:
     description: 'Whether to force a new deployment of the service. Valid value is "true". Will default to not force a new deployment.'
     required: false
-  #one off task inputs
   run-task:
     description: 'A boolean indicating whether to run a stand-alone task in a ECS cluster. Task will run before the service is updated if both are provided. Default value is false .'
     required: false
@@ -64,8 +63,7 @@ inputs:
     required: false
   wait-for-task-stopped:
     description: 'Whether to wait for the task to stop when running it outside of a service. Will default to not wait.'
-    required: false
-#back to original inputs 
+    required: false 
 outputs:
   task-definition-arn:
     description: 'The ARN of the registered ECS task definition'

dist/index.js

@@ -26,8 +26,8 @@ const IGNORED_TASK_DEFINITION_ATTRIBUTES = [
   'registeredBy'
 ];
 
-//Code to run task outside of a service aka (also known as) a one-off task
-async function runTask(ecs,clusterName, taskDefArn, waitForMinutes) {
+//method to run a stand-alone task with dersired inputs
+async function runTask(ecs, clusterName, taskDefArn, waitForMinutes) {
   core.info('Running task')
 
   const waitForTask = core.getInput('wait-for-task-stopped', { required: false }) || 'false';
@@ -61,10 +61,8 @@ async function runTask(ecs,clusterName, taskDefArn, waitForMinutes) {
     },
     launchType: launchType,
     networkConfiguration: Object.keys(awsvpcConfiguration).length === 0 ? {} : { awsvpcConfiguration: awsvpcConfiguration },
-
   });
 
-
   core.debug(`Run task response ${JSON.stringify(runTaskResponse)}`)
 
   const taskArns = runTaskResponse.tasks.map(task => task.taskArn);
@@ -73,7 +71,6 @@ async function runTask(ecs,clusterName, taskDefArn, waitForMinutes) {
   const region = await ecs.config.region();
   const consoleHostname = region.startsWith('cn') ? 'console.amazonaws.cn' : 'console.aws.amazon.com';
 
-
   core.info(`Task running: https://${consoleHostname}/ecs/home?region=${region}#/clusters/${clusterName}/tasks`);
 
 
@@ -137,7 +134,6 @@ async function tasksExitCode(ecs, clusterName, taskArns) {
   }
 }
 
-
 // Deploy to a service that uses the 'ECS' deployment controller
 async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForService, waitForMinutes, forceNewDeployment, desiredCount) {
   core.debug('Updating the service');
@@ -431,7 +427,6 @@ async function run() {
 
     // Update the service with the new task definition
     if (service) {
-      
       // Determine the deployment controller
       const describeResponse = await ecs.describeServices({
         services: [service],

index.js

@@ -20,8 +20,8 @@ const IGNORED_TASK_DEFINITION_ATTRIBUTES = [
   'registeredBy'
 ];
 
-//Code to run task outside of a service aka (also known as) a one-off task
-async function runTask(ecs,clusterName, taskDefArn, waitForMinutes) {
+//method to run a stand-alone task with dersired inputs
+async function runTask(ecs, clusterName, taskDefArn, waitForMinutes) {
   core.info('Running task')
 
   const waitForTask = core.getInput('wait-for-task-stopped', { required: false }) || 'false';
@@ -55,10 +55,8 @@ async function runTask(ecs,clusterName, taskDefArn, waitForMinutes) {
     },
     launchType: launchType,
     networkConfiguration: Object.keys(awsvpcConfiguration).length === 0 ? {} : { awsvpcConfiguration: awsvpcConfiguration },
-
   });
 
-
   core.debug(`Run task response ${JSON.stringify(runTaskResponse)}`)
 
   const taskArns = runTaskResponse.tasks.map(task => task.taskArn);
@@ -67,7 +65,6 @@ async function runTask(ecs,clusterName, taskDefArn, waitForMinutes) {
   const region = await ecs.config.region();
   const consoleHostname = region.startsWith('cn') ? 'console.amazonaws.cn' : 'console.aws.amazon.com';
 
-
   core.info(`Task running: https://${consoleHostname}/ecs/home?region=${region}#/clusters/${clusterName}/tasks`);
 
 
@@ -131,7 +128,6 @@ async function tasksExitCode(ecs, clusterName, taskArns) {
   }
 }
 
-
 // Deploy to a service that uses the 'ECS' deployment controller
 async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForService, waitForMinutes, forceNewDeployment, desiredCount) {
   core.debug('Updating the service');
@@ -425,7 +421,6 @@ async function run() {
 
     // Update the service with the new task definition
     if (service) {
-      
       // Determine the deployment controller
       const describeResponse = await ecs.describeServices({
         services: [service],