Skip to content

Add new integration tests for newly added one off task #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jul 31, 2024
Merged

Add new integration tests for newly added one off task #594

Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
3202f19
update tasks only feature
shesaave Jun 24, 2024
c8a36e1
merge with remote
shesaave Jul 29, 2024
b92d314
new integration tests
shesaave Jul 29, 2024
d833b92
new integration tests with env variables defined
shesaave Jul 29, 2024
98f6d60
updated inputs
shesaave Jul 29, 2024
57829c7
updated cluster inputs
shesaave Jul 29, 2024
b586061
updated region
shesaave Jul 30, 2024
5c3d9db
Update test-workflow.yml
shesaave Jul 30, 2024
b886b56
updated subnet values
shesaave Jul 30, 2024
774a9bb
updated subnet values
shesaave Jul 30, 2024
038fdd1
updated values to link to my subnets, repo, cluster, and my service
shesaave Jul 30, 2024
f017483
update security group
shesaave Jul 30, 2024
b2e6e58
modified workflow to add public IP and task definition with proper in…
shesaave Jul 30, 2024
ef56b9c
new task def file and yaml file changes
shesaave Jul 30, 2024
4247e8f
updated task def run task file with different container information
shesaave Jul 30, 2024
91e9ed2
updated task def run task file with new cpu
shesaave Jul 30, 2024
a63b1ef
new changes for integ tests with deploy task def credentials
shesaave Jul 30, 2024
5097930
updating task definition
shesaave Jul 30, 2024
23d4244
updating env variables to inputs
shesaave Jul 30, 2024
a84b8c8
updated region
shesaave Jul 30, 2024
b5db699
updated env to both workflow files
shesaave Jul 30, 2024
3d45493
removing env block
shesaave Jul 30, 2024
87b02dc
removing old commit and using commit from offical deploy repo
shesaave Jul 30, 2024
cb5f1e8
new echo integ test run no.
shesaave Jul 30, 2024
777e820
update original task definition
shesaave Jul 30, 2024
2b2e22b
remove public IP input
shesaave Jul 30, 2024
d3be320
keep only basic run task inputs
shesaave Jul 30, 2024
58c566a
original inputs and different security group
shesaave Jul 30, 2024
071cc21
final changes
shesaave Jul 30, 2024
2d78ba5
made changes from comments
shesaave Jul 31, 2024
61116d5
Delete .idea/.gitignore
shesaave Jul 31, 2024
e6db5fa
Delete .idea/vcs.xml
shesaave Jul 31, 2024
cf87c53
Delete .idea/amazon-ecs-deploy-task-definition.iml
shesaave Jul 31, 2024
ffc13d1
Delete .idea/inspectionProfiles/Project_Default.xml
shesaave Jul 31, 2024
b405799
Delete .idea/misc.xml
shesaave Jul 31, 2024
69c279d
Delete .idea/modules.xml
shesaave Jul 31, 2024
4cc8fdc
clearer description name of each test
shesaave Jul 31, 2024
767cfb3
clearer description name of each test
shesaave Jul 31, 2024
9d2ad13
Merge branch 'integ-tests' into integ-tests
shesaave Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion .github/workflows/test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,32 @@ jobs:
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: us-west-2

- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being False
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
with:
task-definition: task-definition-run-task.json
cluster: github-actions-deploy-task-def-integ-test
run-task: true
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
run-task-security-groups: sg-067ebcde49c0f3ad8
run-task-launch-type: FARGATE
wait-for-task-stopped: false

- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being True
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
with:
task-definition: task-definition-run-task.json
cluster: github-actions-deploy-task-def-integ-test
run-task: true
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
run-task-security-groups: sg-067ebcde49c0f3ad8
run-task-launch-type: FARGATE
wait-for-task-stopped: true

- name: Deploy Amazon ECS task definition
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
with:
task-definition: task-definition.json
service: github-actions-deploy-task-def-integ-test
cluster: github-actions-deploy-task-def-integ-test
wait-for-service-stability: true
wait-for-service-stability: true
25 changes: 25 additions & 0 deletions task-definition-run-task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"containerDefinitions": [
{
"memory": 32,
"essential": true,
"entryPoint": ["ping"],
"name": "alpine_ping",
"readonlyRootFilesystem": true,
"image": "alpine:3.4",
"command": [
"-c",
"4",
"example.com"
],
"cpu": 16
}
],
"memory": "512",
"family": "github-actions-deploy-task-def-integ-tests",
"requiresCompatibilities": [
"FARGATE"
],
"networkMode": "awsvpc",
"cpu": "256"
}
24 changes: 23 additions & 1 deletion test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,32 @@ jobs:
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: us-west-2

- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being False
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
with:
task-definition: task-definition-run-task.json
cluster: github-actions-deploy-task-def-integ-test
run-task: true
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
run-task-security-groups: sg-067ebcde49c0f3ad8
run-task-launch-type: FARGATE
wait-for-task-stopped: false

- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being True
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
with:
task-definition: task-definition-run-task.json
cluster: github-actions-deploy-task-def-integ-test
run-task: true
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
run-task-security-groups: sg-067ebcde49c0f3ad8
run-task-launch-type: FARGATE
wait-for-task-stopped: true

- name: Deploy Amazon ECS task definition
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
with:
task-definition: task-definition.json
service: github-actions-deploy-task-def-integ-test
cluster: github-actions-deploy-task-def-integ-test
wait-for-service-stability: true
wait-for-service-stability: true