Skip to content

feat: Enable AWS managed tags #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 24, 2024
Merged

Conversation

guikcd
Copy link
Contributor

@guikcd guikcd commented Aug 21, 2024

Issue #, if available:
Closes #620

Description of changes:

Determines whether to turn on Amazon ECS managed tags 'aws:ecs:serviceName' and 'aws:ecs:clusterName' for the tasks in the service or the task.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@guikcd guikcd marked this pull request as draft August 21, 2024 12:05
@guikcd guikcd force-pushed the enableECSManagedTags branch 2 times, most recently from 284a472 to e5032d5 Compare August 21, 2024 15:01
@guikcd guikcd marked this pull request as ready for review August 21, 2024 15:04
@guikcd guikcd marked this pull request as draft August 21, 2024 15:04
@guikcd guikcd marked this pull request as ready for review August 22, 2024 15:26
@guikcd guikcd force-pushed the enableECSManagedTags branch from e5032d5 to d73924a Compare August 23, 2024 12:05
@guikcd guikcd force-pushed the enableECSManagedTags branch from d73924a to f103f60 Compare August 23, 2024 12:10
@kg-aws kg-aws changed the title Enable AWS managed tags feat: Enable AWS managed tags Aug 23, 2024
@kg-aws kg-aws self-requested a review August 23, 2024 12:46
@karanbokil
Copy link

Can we also update the readme to reflect the ability to add this new property?

@kg-aws kg-aws requested review from kg-aws and omkhegde August 23, 2024 15:52
@kg-aws kg-aws added work-in-progress mark a PR as WIP to prevent merging do-not-merge labels Aug 23, 2024
@guikcd
Copy link
Contributor Author

guikcd commented Aug 24, 2024

Can we also update the readme to reflect the ability to add this new property?

README updated and flag also enabled for run-task.
I've also removed my dedicated test and modified the existing run task with options to test enable-ecs-managed-tags set to true.

@kg-aws kg-aws added pending-release The change has been merged and is awaiting a release and removed work-in-progress mark a PR as WIP to prevent merging do-not-merge labels Aug 24, 2024
@kg-aws kg-aws merged commit 5ae7be6 into aws-actions:master Aug 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-release The change has been merged and is awaiting a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable enableECSManagedTags for runTask
4 participants