Skip to content

test: run integ tests upon pull request approval #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: run integ tests upon pull request approval #667

wants to merge 1 commit into from

Conversation

dani-chmb
Copy link
Contributor

@dani-chmb dani-chmb commented Oct 30, 2024

Description of changes

Run integration tests upon pull request approval.

Testing

Testing was done in a fork of this repository.

Test Images

Successful Integration Tests Execution

  1. Mock PR prior to review.

preapproval

  1. Mock PR after a review without approval.

non-approved-review

  1. Mock PR after an approving review.

post-approval

Unsuccessful Integration Tests Execution

Additionally, a second pull request was created with an invalid task-definition.json to evaluate integration tests failure behavior with the new changes. As seen on the image below, the integration tests failure is grouped with other pull request checks.

failed-integ-tests

Related PRs

PR 2/2 for running integration tests upon pull-request approval. See other PR for integ-tests branch.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dani-chmb dani-chmb requested a review from kg-aws October 30, 2024 18:18
@dani-chmb dani-chmb closed this Nov 4, 2024
@dani-chmb dani-chmb deleted the pr-approval branch November 4, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant