Skip to content

feat: Add support for maxAttempts to allow retrying after failure#750

Merged
s3cube merged 9 commits intoaws-actions:masterfrom
pcnoic:retries
Jan 16, 2026
Merged

feat: Add support for maxAttempts to allow retrying after failure#750
s3cube merged 9 commits intoaws-actions:masterfrom
pcnoic:retries

Conversation

@pcnoic
Copy link
Contributor

@pcnoic pcnoic commented May 5, 2025

Context

I know there's already an effort to get this change merged here but it seems like it fell through the cracks after the upgrade to AWS SDK for Javascript (v3) took place.

It appears that a lot of users of this action are encountering rate limits when attempting to deploy task definitions in parallel. This should help mitigate the issue.

Implementation

Allows retries using the updated client specs with maxAttempts and retryMode.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pcnoic pcnoic changed the title Add support for maxAttempts to allow retrying when failing Add support for maxAttempts to allow retrying after failure May 6, 2025
@kg-aws kg-aws self-requested a review May 19, 2025 13:56
@kg-aws kg-aws requested review from kg-aws and omkhegde May 19, 2025 14:15
@kg-aws
Copy link
Contributor

kg-aws commented May 19, 2025

@pcnoic - Thank you the PR. The unit test check is failing blocking the merge. The unit test can be run locally with with npm run test command.

@pcnoic
Copy link
Contributor Author

pcnoic commented May 19, 2025

hey @kg-aws - thanks for taking a look. I'll get the unit test fixed.

@kg-aws kg-aws changed the title Add support for maxAttempts to allow retrying after failure feat: Add support for maxAttempts to allow retrying after failure May 20, 2025
@mesaugat
Copy link

mesaugat commented Dec 3, 2025

Hello @omkhegde @kg-aws ... can we get some attention on this change and move it to master? Seems like it has been stale for a while.

cc @pcnoic

@neogibson
Copy link

this would be great for us as well

@pcnoic
Copy link
Contributor Author

pcnoic commented Jan 6, 2026

@kg-aws @omkhegde, could you trigger the workflows? I rebased and resolved the merge conflicts. Unit tests are passing for me.

Sorry, it took me nearly a year.

@VadimPangaev
Copy link

@kg-aws We need that too, could you please help speed this up?

@s3cube s3cube merged commit ede1821 into aws-actions:master Jan 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants