feature: Add keep-null-value-keys parameter (Issue #780) #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzub-resonate
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 780 - Add parameter to keep null or empty keys in taskdef
Added a new parameter called
keep-null-value-keyswhich allows you to provide a csv separated list of keys which should not be dropped if they are empty, this is important for elements that have default values which are populated and you want to override them in the taskdef.In our particular use case we wanted to override the tag parameter to be an empty string as in the splunk logging driver it defaults to a value "{{.ID}}", because of this default and the dropping of empty values this was not possible in the current version.
I added additional unit tests and verified that this action exhibits the correct behavior in our workflow.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.