fix(auth): Return cached user id and username instead of refetching them in getCurrentUser #2985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrentUser This fixes a bug where getCurrentUser returns an error if the device is offline and the access token is expired. The user is still considered "signed in" in this scenario, however, so failing to return the current user is incongruent behaviour
2 tasks
tylerjroach
previously approved these changes
Feb 12, 2025
tylerjroach
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Use the cached user id (this is the "sub" from cognito) and username when invoking
getCurrentUserinstead of trying to fetch and parse a new access token.This fixes a bug where
getCurrentUserreturns an error if the device is offline and the access token is expired. The user is still considered "signed in" in this scenario, however, so failing to return the current user is incongruent behaviour.How did you test these changes?
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.