Skip to content

Conversation

@mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented Mar 5, 2025

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Moves signUp, confirmSignUp, and resendSignupCode to usecase classes.
This PR adds lines because signUp and confirmSignUp did not have good unit test coverage, that has been improved in this PR.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner March 5, 2025 08:16
@mattcreaser mattcreaser merged commit e184403 into main Mar 10, 2025
4 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/usecase-signup branch March 10, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants