feat(foundation): Add foundation modules to feature branch#3193
Merged
mattcreaser merged 18 commits intofeat/foundationfrom Feb 5, 2026
Merged
feat(foundation): Add foundation modules to feature branch#3193mattcreaser merged 18 commits intofeat/foundationfrom
mattcreaser merged 18 commits intofeat/foundationfrom
Conversation
Don't expect to need this function
jvh-aws
reviewed
Feb 3, 2026
...e/src/commonTest/kotlin/com/amplifyframework/foundation/credentials/SmithyCredentialsTest.kt
Show resolved
Hide resolved
| when (this) { | ||
| is Result.Failure -> Result.Failure(mapFailure(this.error)) | ||
| is Result.Success -> Result.Success(mapSuccess(this.data)) | ||
| } |
Contributor
There was a problem hiding this comment.
Does an implementation for runCatching make sense here?
Member
Author
There was a problem hiding this comment.
Probably, yes. I just didn't want to go too crazy with extensions and utilities before they are actually needed. We can add such functions as they become necessary.
Contributor
There was a problem hiding this comment.
I'm already using it in the feat/kinesis branch. But we can also add it in a separate PR to unblock the current one.
jvh-aws
approved these changes
Feb 5, 2026
jvh-aws
reviewed
Feb 5, 2026
| ", cause=" + cause + | ||
| ", recoverySuggestion=" + recoverySuggestion + | ||
| '}' | ||
| ) |
Contributor
There was a problem hiding this comment.
nit: We could use dollar notation here, e.g.
"${getClass().getSimpleName()}{message=${getMessage()}, cause=${...}...}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds
foundationandfoundation-bridgemodules with some initial classes to the foundation feature branch.How did you test these changes?
Documentation update required?
General Checklist
fix(storage): message,feat(auth): message,chore(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.