Skip to content

Fix constructor for kinesis record sender #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattcreaser merged 1 commit into from
Feb 9, 2026
+8 −16
Merged

Fix constructor for kinesis record sender #3195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions aws-kinesis/src/main/java/com/amplifyframework/kinesis/KinesisRecordSender.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,13 @@ import com.amplifyframework.recordcache.RecordSender
typealias PutRecordsResponseSdk = aws.sdk.kotlin.services.kinesis.model.PutRecordsResponse

internal class KinesisRecordSender(
val credentialsProvider: AWSCredentialsProvider<out AWSCredentials>,
val region: String,
val maxRetries: Int
private val credentialsProvider: AWSCredentialsProvider<AWSCredentials>,
private val region: String,
private val maxRetries: Int,
) : RecordSender {
@VisibleForTesting
lateinit var kinesisSDKClient: KinesisClient

init {
createKinesisSDKClient()
}
private fun createKinesisSDKClient() {
kinesisSDKClient = KinesisClient {
region = this@KinesisRecordSender.region
credentialsProvider = convertToSdkCredentialsProvider(this@KinesisRecordSender.credentialsProvider)
}
private val kinesisSDKClient: KinesisClient = KinesisClient {
this.region = this@KinesisRecordSender.region
this.credentialsProvider = convertToSdkCredentialsProvider(this@KinesisRecordSender.credentialsProvider)
}

override suspend fun putRecords(streamName: String, records: List<Record>): Result<PutRecordsResponse> =
Expand All @@ -50,7 +42,7 @@ internal class KinesisRecordSender(
}

@VisibleForTesting
fun createRequest(streamName: String, records: List<Record>) = PutRecordsRequest {
internal fun createRequest(streamName: String, records: List<Record>) = PutRecordsRequest {
this.streamName = streamName
this.records = records.map { record ->
PutRecordsRequestEntry {
Expand All @@ -61,7 +53,7 @@ internal class KinesisRecordSender(
}

@VisibleForTesting
fun splitResponse(response: PutRecordsResponseSdk, records: List<Record>): PutRecordsResponse {
internal fun splitResponse(response: PutRecordsResponseSdk, records: List<Record>): PutRecordsResponse {
val successfulIds = mutableListOf<Long>()
val retryableIds = mutableListOf<Long>()
val failedIds = mutableListOf<Long>()
Expand Down