Skip to content

Commit 08c2242

Browse files
authored
fix: health checks fail on bash code where ps script is expected (#3006)
1 parent f74ad0b commit 08c2242

File tree

1 file changed

+20
-15
lines changed

1 file changed

+20
-15
lines changed

.github/workflows/health_checks.yml

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -478,16 +478,17 @@ jobs:
478478
contents: read
479479
steps:
480480
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
481+
- name: Set file descriptor limit on macOS
482+
if: runner.os == 'macOS'
483+
run: ulimit -n 10000
481484
- name: Run e2e deployment tests
482485
uses: ./.github/actions/run_with_e2e_account
483486
with:
484487
e2e_test_accounts: ${{ vars.E2E_TEST_ACCOUNTS }}
485488
node_version: ${{ matrix.node-version }}
486489
cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
487490
link_cli: true
488-
run: |
489-
[[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
490-
npm run test:dir ${{ matrix.testPaths }}
491+
run: npm run test:dir ${{ matrix.testPaths }}
491492
e2e_generate_sandbox_tests_matrix:
492493
if: needs.do_include_e2e.outputs.run_e2e == 'true'
493494
runs-on: ubuntu-latest
@@ -527,16 +528,17 @@ jobs:
527528
contents: read
528529
steps:
529530
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
531+
- name: Set file descriptor limit on macOS
532+
if: runner.os == 'macOS'
533+
run: ulimit -n 10000
530534
- name: Run e2e sandbox tests
531535
uses: ./.github/actions/run_with_e2e_account
532536
with:
533537
e2e_test_accounts: ${{ vars.E2E_TEST_ACCOUNTS }}
534538
node_version: ${{ matrix.node-version }}
535539
cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
536540
link_cli: true
537-
run: |
538-
[[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
539-
npm run test:dir ${{ matrix.testPaths }}
541+
run: npm run test:dir ${{ matrix.testPaths }}
540542
e2e_notices:
541543
if: needs.do_include_e2e.outputs.run_e2e == 'true'
542544
strategy:
@@ -565,10 +567,11 @@ jobs:
565567
node-version: 18
566568
cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
567569
- run: cd packages/cli && npm link
570+
- name: Set file descriptor limit on macOS
571+
if: runner.os == 'macOS'
572+
run: ulimit -n 10000
568573
- name: Run e2e notices tests
569-
run: |
570-
[[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
571-
npm run test:dir packages/integration-tests/lib/test-e2e/notices.test.js
574+
run: npm run test:dir packages/integration-tests/lib/test-e2e/notices.test.js
572575
e2e_backend_output:
573576
if: needs.do_include_e2e.outputs.run_e2e == 'true'
574577
runs-on: ubuntu-latest
@@ -625,10 +628,11 @@ jobs:
625628
node-version: ${{ matrix.node-version }}
626629
cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
627630
- run: cd packages/cli && npm link
631+
- name: Set file descriptor limit on macOS
632+
if: runner.os == 'macOS'
633+
run: ulimit -n 10000
628634
- name: Run e2e create-amplify tests
629-
run: |
630-
[[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
631-
npm run test:dir packages/integration-tests/lib/test-e2e/create_amplify.test.js
635+
run: npm run test:dir packages/integration-tests/lib/test-e2e/create_amplify.test.js
632636
e2e_package_manager:
633637
if: needs.do_include_e2e.outputs.run_e2e == 'true' && needs.do_include_e2e.outputs.include_package_manager_e2e == 'true'
634638
strategy:
@@ -653,16 +657,17 @@ jobs:
653657
steps:
654658
- name: Checkout aws-amplify/amplify-backend repo
655659
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
660+
- name: Set file descriptor limit on macOS
661+
if: runner.os == 'macOS'
662+
run: ulimit -n 10000
656663
- name: Run E2E flow tests with ${{ matrix.pkg-manager }}
657664
uses: ./.github/actions/run_with_e2e_account
658665
with:
659666
e2e_test_accounts: ${{ vars.E2E_TEST_ACCOUNTS }}
660667
node_version: ${{ matrix.node-version }}
661668
cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
662669
shell: bash
663-
run: |
664-
[[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
665-
PACKAGE_MANAGER=${{matrix.pkg-manager}} npm run test:dir packages/integration-tests/src/package_manager_sanity_checks.test.ts
670+
run: PACKAGE_MANAGER=${{matrix.pkg-manager}} npm run test:dir packages/integration-tests/src/package_manager_sanity_checks.test.ts
666671
lint:
667672
runs-on: ubuntu-latest
668673
needs:

0 commit comments

Comments
 (0)