Skip to content

Commit fc21576

Browse files
rix0rrrmrgrain
andauthored
chore: raise FD limit on MacOS in health_check tests (#2996)
MacOS tests are failing with `getaddrinfo ENOTFOUND`. Chasing a suspicion that this may be us hitting FD limits, raise the FD limits from 2560 to 10000, and see if that improves reliability. Co-authored-by: Momo Kornher <[email protected]>
1 parent 8cbd5b9 commit fc21576

File tree

2 files changed

+26
-0
lines changed

2 files changed

+26
-0
lines changed

.changeset/silent-peas-vanish.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

.github/workflows/health_checks.yml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,10 @@ jobs:
150150
timeout-minutes: 15
151151
steps:
152152
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
153+
- name: Increase ulimit
154+
if: runner.os == 'macOS'
155+
run: |
156+
ulimit -n 10000
153157
- uses: ./.github/actions/setup_node
154158
with:
155159
node-version: ${{ matrix.node }}
@@ -478,6 +482,10 @@ jobs:
478482
contents: read
479483
steps:
480484
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
485+
- name: Increase ulimit
486+
if: runner.os == 'macOS'
487+
run: |
488+
ulimit -n 10000
481489
- name: Run e2e deployment tests
482490
uses: ./.github/actions/run_with_e2e_account
483491
with:
@@ -526,6 +534,10 @@ jobs:
526534
contents: read
527535
steps:
528536
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
537+
- name: Increase ulimit
538+
if: runner.os == 'macOS'
539+
run: |
540+
ulimit -n 10000
529541
- name: Run e2e sandbox tests
530542
uses: ./.github/actions/run_with_e2e_account
531543
with:
@@ -554,6 +566,10 @@ jobs:
554566
contents: read
555567
steps:
556568
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
569+
- name: Increase ulimit
570+
if: runner.os == 'macOS'
571+
run: |
572+
ulimit -n 10000
557573
- uses: ./.github/actions/setup_node
558574
with:
559575
node-version: 18
@@ -612,6 +628,10 @@ jobs:
612628
- resolve_inputs
613629
steps:
614630
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
631+
- name: Increase ulimit
632+
if: runner.os == 'macOS'
633+
run: |
634+
ulimit -n 10000
615635
- uses: ./.github/actions/setup_node
616636
with:
617637
node-version: ${{ matrix.node-version }}
@@ -644,6 +664,10 @@ jobs:
644664
id-token: write
645665
contents: read
646666
steps:
667+
- name: Increase ulimit
668+
if: runner.os == 'macOS'
669+
run: |
670+
ulimit -n 10000
647671
- name: Checkout aws-amplify/amplify-backend repo
648672
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
649673
- name: Run E2E flow tests with ${{ matrix.pkg-manager }}

0 commit comments

Comments
 (0)