-
Notifications
You must be signed in to change notification settings - Fork 102
feat: support custom SSL certificates in SQL data sources #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 331f369 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
"type": "module", | ||
"scripts": { | ||
"build": "tsc --build packages/* && tsc --build scripts", | ||
"build": "tsc --build packages/* scripts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--build
takes multiple source directories as arguments. The previous construction of this command meant that the --watch
argument from the watch
script ("npm run build -- --watch"
) only applied to tsc --build scripts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionally LGTM, just a comment on the changeset
Converting to draft to wait for amplify-category-api release, to consume aws-amplify/amplify-category-api#2680, which fixes the attribute name created by |
amplify-category-api release is complete, ready to re-review |
Problem
Enables end-to-end support for custom SSL certificates in SQL data sources by tying together all of:
Docs update: aws-amplify/docs#7802
New public API
Data schema configuration now includes the ability to define an
sslCert
secret.The
sslCert
secret will be resolved at deploy time and passed to the CDK constructsslCertConfig
setting added in the@aws-amplify/data-construct
1.9.0 release.Changeset
This change introduces a new feature API. The only code changes are in
@aws-amplify/backend-data
. There are explicit dependency updates in both@aws-amplify/backend-data
and@aws-amplify/schema-generator
:@aws-amplify/backend-data
@aws-amplify/schema-generator
Validation
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.