Skip to content

fix: maintain custom sandbox identifier after file changes #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: maintain custom sandbox identifier after file changes #2875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fix-sandbox-identifier-persistence.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@aws-amplify/sandbox': patch
---

fix: maintain custom sandbox identifier after file changes

The sandbox identifier provided via --identifier flag now persists throughout the entire session, including after file changes trigger rebuilds. Previously, the identifier would fall back to the default (whoami) value after file changes.
2 changes: 1 addition & 1 deletion packages/sandbox/src/file_watching_sandbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export class FileWatchingSandbox extends EventEmitter implements Sandbox {
this.filesChangesTracker.trackFileChange(filePath);
if (latch === 'open') {
this.printer.clearConsole();
await this.printSandboxNameInfo();
await this.printSandboxNameInfo(options.identifier);
}
this.printer.log(
`[Sandbox] Triggered due to a file ${eventName} event: ${path.relative(
Expand Down