fix: populate custom resources CDK stacks with region and account (#12575) #13316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtpascual
reviewed
Oct 9, 2023
0618
reviewed
Oct 9, 2023
0618
approved these changes
Oct 9, 2023
rtpascual
approved these changes
Oct 9, 2023
sobolk
reviewed
Oct 10, 2023
Comment on lines
+148
to
+151
| // should pickup to default cdk env vars and build cfn stack. | ||
| process.env.CDK_DEFAULT_ACCOUNT = 'some_id'; | ||
| process.env.CDK_DEFAULT_REGION = process.env.CLI_REGION; | ||
| await amplifyPushAuth(projRoot); |
There was a problem hiding this comment.
this lacks assertion.
we have developed the following mechanism in override tests to assert that injected values actually work
amplify-cli/packages/amplify-e2e-tests/overrides/override-auth.ts
Lines 15 to 21 in d60e505
Can we please use similar pattern in
barebone-cdk-stack.ts ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Custom resource should populate with region and account from CDK default variables.
https://docs.aws.amazon.com/cdk/v2/guide/environments.html
Issue #, if available
#12575
Description of how you validated changes
Manual testing, unit test & e2e tests added
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.