chore: log error for stackUpdateComplete #13773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0618
commented
May 10, 2024
packages/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts
Outdated
Show resolved
Hide resolved
johnpc
previously approved these changes
May 10, 2024
Amplifiyer
reviewed
May 10, 2024
packages/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts
Outdated
Show resolved
Hide resolved
added 2 commits
May 11, 2024 13:43
sobolk
previously approved these changes
May 13, 2024
sobolk
reviewed
May 13, 2024
packages/amplify-provider-awscloudformation/src/aws-utils/aws-cfn.js
Outdated
Show resolved
Hide resolved
…cfn.js Co-authored-by: Kamil Sobol <[email protected]>
johnpc
previously approved these changes
May 13, 2024
sobolk
previously approved these changes
May 13, 2024
Amplifiyer
requested changes
May 13, 2024
packages/amplify-provider-awscloudformation/src/aws-utils/aws-cfn.js
Outdated
Show resolved
Hide resolved
Amplifiyer
reviewed
May 14, 2024
Amplifiyer
reviewed
May 15, 2024
packages/amplify-cli/src/__tests__/amplify-exception-handler.test.ts
Outdated
Show resolved
Hide resolved
Amplifiyer
approved these changes
May 15, 2024
sobolk
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When error occurs at
stackUpdateComplete, the error details are logged in another transaction as the error message, which makes it hard when analyzing the log.This PR is to throw the error details with the error messages.
Issue #, if available
Description of how you validated changes
Screenshot 2024-05-11 at 2 09 25 PMe2e test is running in another draft PR #13774
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.