Skip to content

fix: Pascal case enum names in exports block #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MorFix
Copy link

@MorFix MorFix commented Aug 5, 2025

Description of changes

A PR was added removing pascal casing for some enum definitions.
One of the places where pascal casing was actually ADDED is JS models' index.js file that defines enums, then exports them.
However, in the export block, the pascal casing transformation wasn't applied, leading to a potential mismatch between names.

E.g: (enum) MyCTA => MyCta transformation generated a MyCta enum but was trying to export MyCTA

Codegen Paramaters Changed or Added

None

Issue #, if available

None

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified
  • Changes are tested on windows. Some Node functions (such as path) behave differently on windows.
  • Changes adhere to the GraphQL Spec and supports the GraphQL types type, input, enum, interface, union and scalar types.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MorFix MorFix requested a review from a team as a code owner August 5, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant