fix: custom arguments do not support nested custom type arrays/required #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90ee2d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ): { type: 'ref'; link: string; required?: boolean; array?: boolean; arrayRequired?: boolean } => { | ||
| const {valueRequired, array, arrayRequired} = fieldDef.data; | ||
|
|
||
| const customTypeData: { type: 'ref'; link: string; required?: boolean; array?: boolean; arrayRequired?: boolean } = { |
There was a problem hiding this comment.
Can we define a type and use it here instead of typing this inline? Also, did you consider the existing types and see if you can reuse them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds test coverage for nested custom type references with required arrays in custom operations. While investigating related issues around custom type input generation, we identified gaps in test coverage for complex nested scenarios that could lead to regressions.
Issue number, if available: Related to #570 and #547
Changes
pointcustom type structureThese tests ensure the schema processor handles complex nested custom type scenarios properly when generating GraphQL input types for custom operations, particularly around the
constructNonScalarFieldDefinitionfunction andgenerateInputTypeslogic.Corresponding docs PR, if applicable: N/A
Validation
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.