fix(authenticator): add tooltip text to obscure widget and wrap materialbanner content in semantics#6577
Open
ekjotmultani wants to merge 5 commits intomainfrom
Open
fix(authenticator): add tooltip text to obscure widget and wrap materialbanner content in semantics#6577ekjotmultani wants to merge 5 commits intomainfrom
ekjotmultani wants to merge 5 commits intomainfrom
Conversation
…sure text widget on authenticator forms
ekjotmultani
changed the title
ekjotmultani
changed the title
ekjotmultani
force-pushed
the
fix/authenticator/form-field-accessible-names
branch
from
f81873e to
77ba017
Compare
…://github.com/aws-amplify/amplify-flutter into fix/authenticator/form-field-accessible-names
jvh-aws
reviewed
Feb 13, 2026
| 'Please enter the code from your registered Authenticator app'; | ||
|
|
||
| @override | ||
| String get showPassword => 'Show password'; |
Contributor
There was a problem hiding this comment.
This should be generated from the ARB file inputs_en.arb, which should be checked in
Contributor
|
Can we try to update our references in $ cd packages/authenticator/amplify_authenticator
$ flutter test --update-goldensWe should also verify the snapshots to avoid any unnecessary UI changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#6568
#6581
Description of changes:
Adding text on the obscure widget on password fields in forms on Authenticator, making it screen readable, wrapped authenticatorform in semantics so errors are screen readable as ewll (credit @timstarkk for finding these misses)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.