rm "username" from being parsed in amplify_outputs.json auth.username_attributes#13522
Open
josefaidt wants to merge 3 commits intoaws-amplify:mainfrom
Open
rm "username" from being parsed in amplify_outputs.json auth.username_attributes#13522josefaidt wants to merge 3 commits intoaws-amplify:mainfrom
auth.username_attributes#13522josefaidt wants to merge 3 commits intoaws-amplify:mainfrom
Conversation
israx
reviewed
Jun 21, 2024
| phone: username_attributes.includes('phone_number'), | ||
| // Signing in with a username is not currently supported in Gen2, this should always evaluate to false | ||
| username: username_attributes.includes('username'), | ||
| username: username_attributes.length === 0, |
Contributor
There was a problem hiding this comment.
if the backend is changing, then this fix makes sense. But I wonder if we should also support previous versions to avoid any breaking change.
Suggested change
| username: username_attributes.length === 0, | |
| username: username_attributes.length === 0 || username_attributes.includes('username') , |
Contributor
Author
There was a problem hiding this comment.
this was written with the outputs schema that had a reference to "username" for this value, however "username" would not be emitted from the construct. for this field, the absence of username attributes indicates "username"
…m-outputs-username-attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
modifies
parseAmplifyOutputsto look for an empty array inauth.username_attributesinstead of["username"]to determine whether logging in with username is enabledthis is related to a similar change in the backend repo to remove
usernamefrom the list ofusername_attributesin the outputs schema aws-amplify/amplify-backend#1636valid
username_attributesproperties includeemailandphone_numberhttps://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_cognito.CfnUserPool.html#usernameattributesthese values come from the L1 CfnUserPool property, therefore will not include
usernamebut the absence of attributes that can be used in place of the usernamehttps://github.com/aws-amplify/amplify-backend/blob/main/packages/auth-construct/src/construct.ts?rgh-link-date=2024-06-19T22%3A39%3A40Z#L952
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.