test(auth): add comprehensive token refresh test coverage #14688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgbezerra
requested review from
avi-karthik,
pranavosu and
sarayev
as code owners
…y#14618) Add test cases for the getTokens() method in TokenOrchestrator to verify token refresh behavior when tokens expire. These tests prove that: - Expired access tokens trigger automatic refresh - Expired ID tokens trigger automatic refresh - forceRefresh option works correctly with valid tokens - signInDetails are preserved after token refresh - NotAuthorizedException returns null and clears tokens - Network errors are thrown (not swallowed) - clientMetadata is passed to the token refresher - New tokens are stored after successful refresh All 12 new tests pass, confirming the core token refresh logic works as expected. This suggests issues reported in aws-amplify#14618 may be related to specific user configurations rather than the refresh mechanism itself. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
pgbezerra
force-pushed
the
test/token-refresh-coverage-14618
branch
from
c750c9b to
df5b60e
Compare
This was referenced Jan 26, 2026
Author
|
Implemented in #14689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for the
getTokens()method inTokenOrchestratorto verify token refresh behavior. These tests were created to investigate issue #14618 where users reported that tokens were not being refreshed automatically.New Test Cases
Test Results
All 22 tests pass in
tokenOrchestrator.test.ts(10 existing + 12 new), and all 1156 tests pass in the auth package with no regressions.Findings
These tests prove that the core token refresh logic is working correctly:
forceRefreshoption works as expectedsignInDetailsare preserved after refreshThis suggests that issues reported in #14618 may be related to specific user configurations (token storage, Cognito settings, race conditions, etc.) rather than the core refresh mechanism itself.
Related Issues