chore(ci): upgrade dependency rexml version to 3.3.9 #3909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edisooon
changed the title
sebaland
suggested changes
Oct 29, 2024
Gemfile
Outdated
| gem 'xcpretty', '0.3.0' | ||
| gem 'fastlane', '2.205.1' | ||
| gem 'jazzy', '0.15.1' | ||
| gem 'rexml', '3.3.9' |
There was a problem hiding this comment.
Doing this will fail the Dependency Check because it pulls a newer json version that has an incompatible license.
Instead, just run sudo bundle update rexml in both locations.
There was a problem hiding this comment.
thank you for the explanation!!
added 4 commits
October 29, 2024 09:24
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3909 +/- ##
==========================================
- Coverage 69.20% 69.19% -0.02%
==========================================
Files 1087 1087
Lines 49366 49366
==========================================
- Hits 34163 34158 -5
- Misses 15203 15208 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sebaland
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
https://github.com/aws-amplify/amplify-swift/security/dependabot/26
https://github.com/aws-amplify/amplify-swift/security/dependabot/25
Description
upgrade rexml to 3.3.9 to the Gemfile, and ran bundle update
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.