Skip to content

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jun 27, 2025

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner June 27, 2025 15:04
@harsh62 harsh62 temporarily deployed to IntegrationTest June 27, 2025 15:07 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest June 27, 2025 15:07 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest June 27, 2025 15:07 — with GitHub Actions Inactive
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.84%. Comparing base (d56a2e9) to head (048a387).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4012      +/-   ##
==========================================
+ Coverage   67.69%   67.84%   +0.14%     
==========================================
  Files        1128     1128              
  Lines       52481    52479       -2     
==========================================
+ Hits        35529    35605      +76     
+ Misses      16952    16874      -78     
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (ø)
AWSPluginsCore 69.26% <ø> (+0.05%) ⬆️
Amplify 47.82% <ø> (ø)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.72% <ø> (+0.03%) ⬆️
DataStore_plugin_unit_test 84.17% <ø> (+0.77%) ⬆️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.53% <ø> (ø)
Predictions_plugin_unit_test 35.40% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 76.87% <ø> (ø)
unit_tests 67.84% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh62 harsh62 merged commit a002c54 into main Jun 27, 2025
155 of 159 checks passed
@harsh62 harsh62 deleted the fix-api branch June 27, 2025 16:02
harsh62 added a commit that referenced this pull request Sep 9, 2025
harsh62 added a commit that referenced this pull request Sep 10, 2025
another try

Revert "fix(api): fixing mis-classified errors (#4012)"

This reverts commit a002c54.

Revert "fix(api): fix subscription failures (#3998)"

This reverts commit 70f56f6.

fix

push

Update WebSocketClient.swift
harsh62 added a commit that referenced this pull request Sep 10, 2025
another try

Revert "fix(api): fixing mis-classified errors (#4012)"

This reverts commit a002c54.

Revert "fix(api): fix subscription failures (#3998)"

This reverts commit 70f56f6.

fix

push

Update WebSocketClient.swift

Revert "test"

This reverts commit 1a4ce4d.

chore: fix integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants