Skip to content

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jul 29, 2025

Issue #

#4021

Minimum supported Xcode version

Based on Apples bump to the minimum Xcode version required for uploading apps, Amplify will also update its minimum supported Xcode version to 16.

Dependency update:

  • Updated the AWS SDK Swift package in Package.swift from version 1.2.59 to 1.5.x to incorporate the latest features and fixes.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner July 29, 2025 13:25
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:29 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:29 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:30 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:31 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:31 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:31 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:31 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 29, 2025 13:31 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.72%. Comparing base (e3d6f63) to head (73ddd1e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...n/Dependency/AWSS3PreSignedURLBuilderAdapter.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4028      +/-   ##
==========================================
+ Coverage   67.51%   67.72%   +0.20%     
==========================================
  Files        1130     1129       -1     
  Lines       52639    52487     -152     
==========================================
+ Hits        35539    35545       +6     
+ Misses      17100    16942     -158     
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (-0.03%) ⬇️
AWSPluginsCore 69.26% <ø> (ø)
Amplify 47.82% <ø> (ø)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.59% <ø> (+0.04%) ⬆️
DataStore_plugin_unit_test 83.31% <ø> (ø)
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.53% <ø> (ø)
Predictions_plugin_unit_test 34.77% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 79.39% <0.00%> (+2.52%) ⬆️
unit_tests 67.72% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh62 harsh62 requested a review from a team as a code owner July 31, 2025 17:58
@harsh62 harsh62 changed the title feat: bump swift sdk version to 1.5.8 feat: bump swift sdk version to 1.5.x Jul 31, 2025
]
let dependencies: [Package.Dependency] = [
.package(url: "https://github.com/awslabs/aws-sdk-swift", exact: "1.2.59"),
.package(url: "https://github.com/awslabs/aws-sdk-swift", exact: "1.5.10"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move to from:1.5.10 ?

@harsh62 harsh62 merged commit a1b82a6 into main Aug 1, 2025
155 of 157 checks passed
@harsh62 harsh62 deleted the aws-swift-sdk-udpate-1.5.8 branch August 1, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants