Skip to content

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Aug 11, 2025

Issue #

Why

  • GitHub Actions removed base simulators from Xcode 16.0, breaking minimum version builds
  • Push Notification tests failing due to simulator set conflicts

What

  • Auto-download missing simulators for Xcode 16.0 via new composite action
  • Fix Push Notification tests by aligning with working WebAuthn approach (remove --set testing flags)
  • Add Xcode beta workflow for testing future versions
  • Improve device ID extraction with fallback strategies for clone devices

Refer: https://github.blog/changelog/2025-07-11-upcoming-changes-to-macos-hosted-runners-macos-latest-migration-and-xcode-support-policy-updates

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested review from a team as code owners August 11, 2025 09:08
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.76%. Comparing base (1867326) to head (e9a03c9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4036      +/-   ##
==========================================
- Coverage   67.78%   67.76%   -0.03%     
==========================================
  Files        1129     1129              
  Lines       52478    52478              
==========================================
- Hits        35574    35561      -13     
- Misses      16904    16917      +13     
Flag Coverage Δ
API_plugin_unit_test 70.09% <ø> (-0.24%) ⬇️
AWSPluginsCore 69.25% <ø> (ø)
Amplify 47.96% <ø> (+0.03%) ⬆️
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.63% <ø> (+0.01%) ⬆️
DataStore_plugin_unit_test 83.26% <ø> (-0.10%) ⬇️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 65.27% <ø> (ø)
Predictions_plugin_unit_test 34.77% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 79.39% <ø> (ø)
unit_tests 67.76% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 11, 2025 10:51 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:11 — with GitHub Actions Inactive
strategy:
fail-fast: false
matrix:
platform: [macOS]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why only macOS?

@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:45 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:45 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest August 14, 2025 20:45 — with GitHub Actions Inactive
@harsh62 harsh62 merged commit 5866f82 into main Aug 15, 2025
197 of 202 checks passed
@harsh62 harsh62 deleted the github-action-updates branch August 15, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants