Skip to content

Conversation

ekjotmultani
Copy link
Member

@ekjotmultani ekjotmultani commented Sep 4, 2025

Changed InitiateAuth API for refreshing Cognito User Pool tokens to the new GetTokensFromRefreshToken API which enables a user to rotate their refresh token if they have the feature enabled

Additionally updated the AWS Swift SDK version which fixed a bug in this API

Issue #

#4027

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ekjotmultani ekjotmultani changed the title Feat/refresh token rotation feat(auth): Refresh Token Rotation Sep 4, 2025
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.93%. Comparing base (1e24d45) to head (9b92f80).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...zationSession/UserPool/RefreshUserPoolTokens.swift 88.88% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4050       +/-   ##
===========================================
- Coverage   78.61%   67.93%   -10.69%     
===========================================
  Files         211     1129      +918     
  Lines       14188    52473    +38285     
===========================================
+ Hits        11154    35647    +24493     
- Misses       3034    16826    +13792     
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (?)
AWSPluginsCore 69.25% <ø> (ø)
Amplify 47.93% <ø> (?)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.59% <88.88%> (?)
DataStore_plugin_unit_test 84.23% <ø> (+0.80%) ⬆️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 65.27% <ø> (ø)
Predictions_plugin_unit_test 34.77% <ø> (?)
PushNotifications_plugin_unit_test 88.43% <ø> (?)
Storage_plugin_unit_test 79.39% <ø> (?)
unit_tests 67.93% <88.88%> (-10.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekjotmultani ekjotmultani marked this pull request as ready for review September 4, 2025 16:06
@ekjotmultani ekjotmultani requested a review from a team as a code owner September 4, 2025 16:06
Copy link
Member

@harsh62 harsh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsh62 harsh62 merged commit 905e9e8 into main Sep 4, 2025
93 of 94 checks passed
@harsh62 harsh62 deleted the feat/refresh_token_rotation branch September 4, 2025 16:10
@ekjotmultani ekjotmultani restored the feat/refresh_token_rotation branch September 12, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants