Skip to content

chore(auth): Refresh Token Rotation Test Fix #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 16, 2025
Merged

chore(auth): Refresh Token Rotation Test Fix #4055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0f1bcfb
removed usage of old refresh token, updated test case to properly che…
ekjotmultani Sep 3, 2025
e0f66dd
updated authfetchsigninsession tests to use GetTokenFromRefreshToken …
ekjotmultani Aug 27, 2025
93ec0fc
updated further tests to use new API as well as auth hub event handle…
ekjotmultani Aug 27, 2025
8ba24e9
updated RefreshUserPoolTokens to use GetTokensFromRefreshToken API to…
ekjotmultani Aug 22, 2025
9b92f80
removed refreshAuth function from initiateAuthInput
ekjotmultani Sep 3, 2025
a8de787
reintroduced ternary operator to fallback to previous token if a null…
ekjotmultani Sep 12, 2025
539388d
Merge branch 'main' into feat/refresh_token_rotation
ekjotmultani Sep 12, 2025
6fa11d4
fixed ternary operator location
ekjotmultani Sep 12, 2025
74a9d88
removed unnecessary test since we don't set tokens to nil anymore
ekjotmultani Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...ognitoAuthPlugin/Actions/RefreshAuthorizationSession/UserPool/RefreshUserPoolTokens.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ struct RefreshUserPoolTokens: Action {

guard let authenticationResult = response?.authenticationResult,
let idToken = authenticationResult.idToken,
let accessToken = authenticationResult.accessToken,
let refreshToken = authenticationResult.refreshToken
let accessToken = authenticationResult.accessToken
else {
let event = RefreshSessionEvent(eventType: .throwError(.invalidTokens))
await dispatcher.send(event)
Expand All @@ -74,7 +73,7 @@ struct RefreshUserPoolTokens: Action {
let userPoolTokens = AWSCognitoUserPoolTokens(
idToken: idToken,
accessToken: accessToken,
refreshToken: refreshToken
refreshToken: authenticationResult.refreshToken ?? existingTokens.refreshToken
)

let signedInData = SignedInData(
Expand Down
37 changes: 0 additions & 37 deletions ...itTests/ActionTests/FetchAuthSession/FetchUserPoolTokens/RefreshUserPoolTokensTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,43 +185,6 @@ class RefreshUserPoolTokensTests: XCTestCase {
userPoolFactory: identityProviderFactory)
)

await fulfillment(
of: [expectation],
timeout: 0.1
)
}
func testRefreshTokenMissing() async {

let expectation = expectation(description: "refreshTokenMissing")
let identityProviderFactory: BasicSRPAuthEnvironment.CognitoUserPoolFactory = {
MockIdentityProvider(
mockGetTokensFromRefreshTokenResponse: { _ in
return GetTokensFromRefreshTokenOutput(
authenticationResult: .init(
accessToken: "accessTokenNew",
expiresIn: 100,
idToken: "idTokenNew",
refreshToken: nil))
}
)
}

let action = RefreshUserPoolTokens(existingSignedIndata: .testData)

await action.execute(
withDispatcher: MockDispatcher { event in

if let userPoolEvent = event as? RefreshSessionEvent,
case let .throwError(error) = userPoolEvent.eventType
{
XCTAssertEqual(error, .invalidTokens)
expectation.fulfill()
}
},
environment: Defaults.makeDefaultAuthEnvironment(
userPoolFactory: identityProviderFactory)
)

await fulfillment(
of: [expectation],
timeout: 0.1
Expand Down
Loading