Skip to content

Conversation

thisisabhash
Copy link
Member

@thisisabhash thisisabhash commented Sep 23, 2025

Issue #

issue_comment github action keeps failing for pull request event as it doesn't have the required permissions to edit a pull request
https://github.com/aws-amplify/amplify-swift/actions/workflows/issue_comment.yml

Description

Run issue_comment only for issue comments

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner September 23, 2025 16:46
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.93%. Comparing base (68dda60) to head (2e6bc7c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4061       +/-   ##
===========================================
+ Coverage   68.00%   81.93%   +13.93%     
===========================================
  Files        1129      176      -953     
  Lines       54486    14234    -40252     
===========================================
- Hits        37051    11663    -25388     
+ Misses      17435     2571    -14864     
Flag Coverage Δ
API_plugin_unit_test ?
AWSPluginsCore ?
Amplify ?
Analytics_plugin_unit_test ?
Auth_plugin_unit_test ?
DataStore_plugin_unit_test 83.45% <ø> (-0.06%) ⬇️
Geo_plugin_unit_test ?
Logging_plugin_unit_test ?
Predictions_plugin_unit_test ?
PushNotifications_plugin_unit_test ?
Storage_plugin_unit_test 78.90% <ø> (ø)
unit_tests 81.93% <ø> (+13.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh62 harsh62 merged commit 6e45ff1 into main Sep 23, 2025
96 checks passed
@harsh62 harsh62 deleted the chore/issue-comment-gh-action branch September 23, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants