Skip to content

chore(auth): update AppSyncSigner #4063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

chore(auth): update AppSyncSigner #4063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b5048a
chore: update AppSyncSigner
thisisabhash Oct 1, 2025
6c210e7
chore: fix tests
thisisabhash Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/AWSCognitoAuthPlugin+AppSyncSigner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ extension AWSCognitoAuthPlugin {
return { request in
try await signAppSyncRequest(
request,

region: region
region: region
)
}
}
Expand Down Expand Up @@ -113,8 +112,6 @@ extension AWSCognitoAuthPlugin {
}

var headers = urlRequest.allHTTPHeaderFields ?? [:]
headers.updateValue(host, forKey: "host")

let httpMethod = (urlRequest.httpMethod?.uppercased())
.flatMap(HTTPMethodType.init(rawValue:)) ?? .get

Expand Down
1 change: 0 additions & 1 deletion ...ins/Auth/Tests/AWSCognitoAuthPluginUnitTests/AWSCognitoAuthPluginAppSyncSignerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ class AWSCognitoAuthPluginAppSyncSignerTests: XCTestCase {
XCTAssertEqual(request.method, .post)
XCTAssertEqual(request.endpoint.port, 443)
XCTAssertEqual(request.endpoint.protocolType, .https)
XCTAssertEqual(request.endpoint.headers.headers, [.init(name: "host", value: "graphql.com")])
guard case let .data(data) = request.body else {
XCTFail("Unexpected body")
return
Expand Down
4 changes: 2 additions & 2 deletions ...s/Auth/Tests/AuthHostApp/AuthIntegrationTests/AppSyncSignerTests/AppSyncSignerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ class AppSyncSignerTests: AWSAuthBaseTest {
XCTFail("Missing headers")
return
}
XCTAssertEqual(headers.count, 4)
XCTAssertEqual(headers.count, 3)
let containsExpectedHeaders = headers.keys.contains(where: { key in
key == "Authorization" || key == "Host" || key == "X-Amz-Security-Token" || key == "X-Amz-Date"
key == "Authorization" || key == "X-Amz-Security-Token" || key == "X-Amz-Date"
})
XCTAssertTrue(containsExpectedHeaders)
}
Expand Down
Loading