Skip to content

Conversation

thisisabhash
Copy link
Member

@thisisabhash thisisabhash commented Oct 9, 2025

Issue #

None

Description

  • This change closes the websocket on a rekognition service exception with a custom defined runtime error. This can be used to teardown sessions/close camera from the FaceLivenessDetectorViewModel.
  • Customer is returned the exception type through onServiceException callback. There is no change regarding this.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner October 9, 2025 20:02
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.14%. Comparing base (cdcda78) to head (4c96097).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...sPlugin/Liveness/Service/FaceLivenessSession.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4072      +/-   ##
==========================================
+ Coverage   67.99%   68.14%   +0.14%     
==========================================
  Files        1129     1129              
  Lines       54483    54487       +4     
==========================================
+ Hits        37048    37128      +80     
+ Misses      17435    17359      -76     
Flag Coverage Δ
API_plugin_unit_test 70.17% <ø> (+0.02%) ⬆️
AWSPluginsCore 69.50% <ø> (-0.04%) ⬇️
Amplify 47.96% <ø> (+0.08%) ⬆️
Analytics_plugin_unit_test 85.59% <ø> (ø)
Auth_plugin_unit_test 73.60% <ø> (+0.01%) ⬆️
DataStore_plugin_unit_test 84.37% <ø> (+0.72%) ⬆️
Geo_plugin_unit_test 75.95% <ø> (ø)
Logging_plugin_unit_test 65.56% <ø> (ø)
Predictions_plugin_unit_test 34.59% <0.00%> (-0.04%) ⬇️
PushNotifications_plugin_unit_test 88.76% <ø> (ø)
Storage_plugin_unit_test 78.90% <ø> (ø)
unit_tests 68.14% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

harsh62
harsh62 previously approved these changes Oct 9, 2025
harsh62
harsh62 previously approved these changes Oct 9, 2025
@thisisabhash thisisabhash changed the title fix(predictions): trigger onComplete callback with runtime error on service exception fix(predictions): close websocket with runtime error on service exception Oct 10, 2025
@thisisabhash thisisabhash merged commit 601a402 into main Oct 13, 2025
154 of 158 checks passed
@thisisabhash thisisabhash deleted the fix/liveness-service-exception-callback branch October 13, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants