Skip to content

Conversation

@thisisabhash
Copy link
Member

@thisisabhash thisisabhash commented Nov 11, 2025

Issue #

#4051

Description

This PR adds support for following OIDC parameters in managed login

  • nonce
  • lang
  • login_hint
  • prompt
  • resource

Cognito documentation: https://docs.aws.amazon.com/cognito/latest/developerguide/authorization-endpoint.html

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner November 11, 2025 21:20
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (0340886) to head (7040bb7).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4096       +/-   ##
===========================================
+ Coverage   66.71%   84.84%   +18.13%     
===========================================
  Files        1129       14     -1115     
  Lines       42500      330    -42170     
===========================================
- Hits        28355      280    -28075     
+ Misses      14145       50    -14095     
Flag Coverage Δ
API_plugin_unit_test ?
AWSPluginsCore ?
Amplify ?
Analytics_plugin_unit_test 84.84% <ø> (ø)
Auth_plugin_unit_test ?
DataStore_plugin_unit_test ?
Geo_plugin_unit_test ?
Logging_plugin_unit_test ?
Predictions_plugin_unit_test ?
PushNotifications_plugin_unit_test ?
Storage_plugin_unit_test ?
unit_tests 84.84% <ø> (+18.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thisisabhash thisisabhash merged commit 10c601c into main Nov 14, 2025
96 checks passed
@thisisabhash thisisabhash deleted the feat/cognito-oidc-parameters branch November 14, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants