Skip to content

chore(auth): refractor handleSignedIn method in AuthenticatorViewModel #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2024
Merged

chore(auth): refractor handleSignedIn method in AuthenticatorViewModel #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e207d43
moveTo SignIn is not needed due to signOut()
Sep 19, 2024
a3684fc
update test cases for when getCurrentUser error with SessionExpiredEx…
Sep 23, 2024
b298a64
retrigger checks
Sep 24, 2024
f3ecebe
Merge branch 'main' into edisonzz/session-expired-exception-handle-re…
mattcreaser Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion authenticator/src/main/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,6 @@ internal class AuthenticatorViewModel(
logger.error(result.error.toString())
logger.error("Current signed in user session has expired, signing out.")
signOut()
moveTo(AuthenticatorStep.SignIn)
} else {
handleGeneralFailure(result.error)
}
Expand Down
4 changes: 2 additions & 2 deletions ...ticator/src/test/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class AuthenticatorViewModelTest {
}

@Test
fun `getCurrentUser error with session expired exception during start results in SignIn state`() = runTest {
fun `getCurrentUser error with session expired exception during start results in being signed out`() = runTest {
coEvery { authProvider.fetchAuthSession() } returns Success(mockAuthSession(isSignedIn = true))
coEvery { authProvider.getCurrentUser() } returns AmplifyResult.Error(SessionExpiredException())

Expand All @@ -143,8 +143,8 @@ class AuthenticatorViewModelTest {
coVerify(exactly = 1) {
authProvider.fetchAuthSession()
authProvider.getCurrentUser()
authProvider.signOut()
}
viewModel.currentStep shouldBe AuthenticatorStep.SignIn
}

@Test
Expand Down