Skip to content

Conversation

@edisooon
Copy link
Contributor

@edisooon edisooon commented Sep 24, 2024

Issue #, if available:

Description of changes:
Added missing test cases in AuthenticatorViewModelTest.kt for when AuthSignInStep is one of the following:

  • CONFIRM_SIGN_IN_WITH_SMS_MFA_CODE
  • CONFIRM_SIGN_IN_WITH_CUSTOM_CHALLENGE
  • CONFIRM_SIGN_IN_WITH_NEW_PASSWORD
  • CONFIRM_SIGN_UP

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edisooon edisooon requested review from a team as code owners September 24, 2024 14:40
mattcreaser
mattcreaser previously approved these changes Sep 24, 2024
Base automatically changed from edisonzz/session-expired-exception-handle-refractor to main September 25, 2024 19:39
@edisooon edisooon dismissed mattcreaser’s stale review September 25, 2024 19:39

The base branch was changed.

@edisooon edisooon merged commit b0d79fc into main Sep 25, 2024
1 check passed
@edisooon edisooon deleted the edisonzz/complete-unit-tests-in-AuthenticatorViewModelTest-signIn-region branch September 25, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants