Skip to content

Conversation

@vincetran
Copy link
Member

@vincetran vincetran commented Jun 27, 2025

Issue #, if available: N/A

Description of changes: These are the client-side changes to support Rekognition's new configuration for the Liveness challenge where the UI component does not render a series of flashing colors on the screen. This configuration is referred to as the "no light" challenge and comes in from Rekognition as the FaceMovementChallenge as opposed to the FaceMovementAndLightClientChallenge.

[Amplify Android PR](https://github.com/aws-amplify/amplify-android/pull/3083)

How did you test these changes? These changes were already approved via the following PRs:

NOTE: There will be one additional change that needs to be made to this PR before this change can be merged. Once Amplify Android's PR has been merged, it needs to be released and then this PR needs to update the dependency to that new version or else the build will fail.

The PR has been updated to bump the Amplify dependency which has the NoLight challenge support https://github.com/aws-amplify/amplify-android/releases/tag/release_v2.29.0

Documentation update required?

  • No
  • Yes [Draft PR](https://github.com/aws-amplify/amplify-ui/pull/6593)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from a team as code owners June 27, 2025 19:43
@vincetran vincetran requested a review from a team as a code owner June 30, 2025 18:40
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 14.97006% with 142 lines in your changes missing coverage. Please review.

Project coverage is 31.79%. Comparing base (f23f847) to head (1b34d18).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   32.39%   31.79%   -0.61%     
==========================================
  Files          96       97       +1     
  Lines        4448     4539      +91     
  Branches      515      530      +15     
==========================================
+ Hits         1441     1443       +2     
- Misses       2892     2980      +88     
- Partials      115      116       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vincetran vincetran merged commit fad42d2 into main Jun 30, 2025
2 of 4 checks passed
@vincetran vincetran deleted the feature/no-light-sku branch June 30, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants