fix(liveness): LivenessCoordinator uses a coroutine scope that cancels on destroy #275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Liveness launches a series of coroutines from the LivenessCoordinator. These were not bound to a controlled coroutine scope, causing the coroutines to potentially outlive the desired lifetime of the Coordinator instance. In particular, the 5 second delay in
launchCameracould cause a session error after the LivenessCoordinator was already destroyed.Updated to hold on to the coroutine scope and cancel when the instance is destroyed.
How did you test these changes?
Documentation update required?
General Checklist
fix(liveness): message,fix(authenticator): message,fix(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.