Open
Conversation
tjleing
force-pushed
the
liveness-integration-tests
branch
from
3c2fcf8 to
32f7856
Compare
tjleing
force-pushed
the
liveness-integration-tests
branch
from
e3ac691 to
5b0b74c
Compare
Contributor
Author
|
closing in favor of #118 |
Co-authored-by: Thomas Leing <leint@amazon.com>
mattcreaser
requested changes
Feb 16, 2024
authenticator/src/test/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModelTest.kt
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| } | ||
| // task runNightlyTestsInDeviceFarmPool { |
Member
There was a problem hiding this comment.
Remove commented-out sections
| implementation(libs.tensorflow.support) | ||
|
|
||
| testImplementation(projects.testing) | ||
| androidTestImplementation(libs.amplify.auth) |
Member
There was a problem hiding this comment.
Is this auth dependency necessary here?
|
|
||
| testImplementation(projects.testing) | ||
| androidTestImplementation(libs.amplify.auth) | ||
| androidTestImplementation(libs.test.compose.junit) |
Member
There was a problem hiding this comment.
Let's wrap all of these testing dependencies up in a bundle in the toml file so that we don't have to repeat this if we add integration tests elsewhere.
|
|
||
| subprojects { | ||
| afterEvaluate { project -> | ||
| if (module_backends.containsKey(project.name)) { |
Member
There was a problem hiding this comment.
This file should be implemented as a convention plugin an then applied in relevant projects. See here for our existing convention plugins.
…tor/AuthenticatorViewModelTest.kt Co-authored-by: Matt Creaser <mattcreaser@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.