Skip to content

chore: fix code scanning alerts #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

chore: fix code scanning alerts #211

merged 2 commits into from
Sep 5, 2025

Conversation

thisisabhash
Copy link
Member

@thisisabhash thisisabhash commented Sep 5, 2025 •
edited
Loading

Issue #, if available:
Fix code scanning alerts
https://github.com/aws-amplify/amplify-ui-swift-liveness/security/code-scanning/1

Description of changes:

  • Add permissions block for GITHUB_TOKEN

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested review from a team as code owners September 5, 2025 15:18
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.47%. Comparing base (c6efb44) to head (b108fda).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   28.86%   28.47%   -0.39%     
==========================================
  Files          58       58              
  Lines        3104     3090      -14     
==========================================
- Hits          896      880      -16     
- Misses       2208     2210       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thisisabhash thisisabhash merged commit 1980776 into main Sep 5, 2025
9 of 10 checks passed
@thisisabhash thisisabhash deleted the fix/code-scanning-alerts branch September 5, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh62 harsh62 harsh62 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisabhash @harsh62