Skip to content

chore: fix code scanning alerts #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2025
Merged

chore: fix code scanning alerts #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2643d20
chore: fix code scanning alerts
thisisabhash Sep 5, 2025
b108fda
update destination simulator for build and unit tests
thisisabhash Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_liveness.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
uses: ./.github/composite_actions/run_xcodebuild
with:
scheme: FaceLiveness
destination: 'platform=iOS Simulator,name=iPhone 15,OS=latest'
destination: 'platform=iOS Simulator,name=iPhone 16 Pro Max,OS=18.5'

confirm-pass:
runs-on: ubuntu-latest
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/liveness_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ on:
pull_request:
branches: [ main ]

permissions:
contents: read

jobs:
test-iOS:
name: Liveness iOS Unit Tests
Expand All @@ -27,5 +30,5 @@ jobs:
with:
scheme: FaceLiveness
token: ${{ secrets.CODECOV_TOKEN }}
destination: 'platform=iOS Simulator,name=iPhone 15,OS=latest'
destination: 'platform=iOS Simulator,name=iPhone 16 Pro Max,OS=18.5'
generate_coverage: true
Loading