Skip to content

feat(collection): Add table type to Collection UI primitive #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

jvh-aws
Copy link
Contributor

@jvh-aws jvh-aws commented Jul 28, 2025

Description of changes

Enable type='table' for the Collection UI primitive as requested by #3166

Issue #, if available

Fixes #3166

Description of how you validated changes

  • Added additional unit test
  • Verify correct HTML is generated when rendering the Collection primitive with type='table'

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jvh-aws jvh-aws requested a review from a team as a code owner July 28, 2025 13:11
Copy link

changeset-bot bot commented Jul 28, 2025

🦋 Changeset detected

Latest commit: 716e25e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@aws-amplify/ui-react Minor
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jvh-aws jvh-aws marked this pull request as draft July 28, 2025 13:13
Copy link
Member

@adrianjoshua-strutt adrianjoshua-strutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a Changeset. There is a comment from the bot in the PR. It is fairly simple to add. There are Patch, Minor and Major. I would suggest that this is a Minor change. It could be considered a patch, as Table was already exposed to the enduser. However, we are also introducing the TableHead

@jvh-aws jvh-aws marked this pull request as ready for review July 29, 2025 08:28
@jvh-aws jvh-aws added the run-tests Adding this label will trigger tests to run label Aug 12, 2025
@jvh-aws
Copy link
Contributor Author

jvh-aws commented Aug 12, 2025

Closing in favor of #6665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-tests Adding this label will trigger tests to run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table support missing in Collection Primitive
3 participants