-
Notifications
You must be signed in to change notification settings - Fork 342
feat: add docs for svelte #6761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 07d9c4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
| ```html | ||
| <script lang="ts"> | ||
| import { Authenticator, useAuthenticator } from '@aws-amplify/ui-vue'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be import { Authenticator, useAuthenticator } from '@aws-amplify/ui-svelte';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the only wrong import. Also check the other examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, yeah. too much copy-pasting 😅
| > | ||
| <LogoLink platform={platform} onClick={onClick} /> | ||
| <MenuButton expanded={expanded} setExpanded={setExpanded} /> | ||
| {/*<MenuButton expanded={expanded} setExpanded={setExpanded} />*/} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description of changes
Add documentation for Svelte and Svelte Authenticator
Issue #, if available
Description of how you validated changes
build and looked at the doc preview.
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.