fix(e2e): add explicit wait and visibility check for geo location search textbox #6822
+62
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch textbox
The map-with-location-search e2e tests were flaky due to race conditions
where cy.findByRole would attempt to interact with the search textbox
before it was fully rendered and visible.
Changes:
- Added timeout: 30000 to all textbox queries to allow more time for rendering
- Added .should('be.visible') assertion before interactions to ensure element is ready
- Applied fix to both common/geo.ts and map-with-location-search.steps.ts
This resolves the 'Unable to find an accessible element with the role textbox'
timeout errors that were causing test failures across multiple PRs.
|
sarayev
previously approved these changes
Jan 28, 2026
Added explicit wait step in Background to ensure the map canvas and search input are rendered before tests attempt to interact with them. This addresses the flaky test failures where the component wasn't fully loaded in CI.
Adding debugging to understand root cause of flaky test: - Log current URL and page content - Capture console errors - Take screenshot before checking for map - Log body HTML length and text content This will help identify why the component isn't rendering in CI.
ahmedhamouda78
force-pushed
the
fix/flaky-geo-location-search-test
branch
from
252f1ba to
52be13d
Compare
added 2 commits
January 28, 2026 15:25
Cypress doesn't allow cy commands inside promise callbacks. Simplified debugging to just take screenshots which will show the page state when the test fails.
Using console.log instead of cy.log to avoid Cypress promise issues. This will output to the CI logs showing: - Current URL - Body HTML length - Body text content - Screenshot of page state
added 2 commits
January 28, 2026 17:08
- Use cy.document() to access DOM directly without promise issues - Log page state, element existence, and content - Add full-page screenshots - Create custom workflow to run only geo tests for faster iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes flaky e2e tests in the map-with-location-search feature that were failing across multiple PRs with timeout errors.
Problem
The tests were experiencing race conditions where
cy.findByRolewould attempt to interact with the search textbox before it was fully rendered and visible, resulting in:Solution
timeout: 30000to all textbox queries to allow more time for rendering.should('be.visible')assertion before interactions to ensure element is readycommon/geo.tsandmap-with-location-search.steps.tsTesting
This fix addresses the flaky test failures seen in recent PRs. The tests should now wait properly for the search input to be visible before attempting to interact with it.
Related Issues
Fixes test failures in: