Skip to content

fix: ensure thread-safe handling of streams in AWSIoT components#5520

Open
zhouzh1 wants to merge 2 commits intoaws-amplify:mainfrom
zhouzh1:fix/awsiot_websocket_stream_concurrency
Open

fix: ensure thread-safe handling of streams in AWSIoT components#5520
zhouzh1 wants to merge 2 commits intoaws-amplify:mainfrom
zhouzh1:fix/awsiot_websocket_stream_concurrency

Conversation

@zhouzh1
Copy link
Copy Markdown

@zhouzh1 zhouzh1 commented May 6, 2025

Issue #, if available:

None

Description of changes:

Actually I already submitted a PR several months ago, but it got declined because of the code change in it is not really able to resolve the issue, but you can get the issue details from that PR.

As for the code change in this PR, I already applied it in our release app for nearly a quarter by creating a pod patch, I can sure it's able to resolve the corresponding issue because we haven't observed the corresponding error report in both Sentry and Xcode crash statistics anymore, but I am not sure if it's the most optimal solution, so please help take a look.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhouzh1 zhouzh1 requested review from a team and awsmobilesdk as code owners May 6, 2025 09:25
@zhouzh1
Copy link
Copy Markdown
Author

zhouzh1 commented May 6, 2025

@mattczech @lyricsboy @hughescr @orta Hey guys, anybody can help review this PR so that we can get rid of the pod patching? Thanks.

@zhouzh1
Copy link
Copy Markdown
Author

zhouzh1 commented May 14, 2025

@awsmobilesdk review, please~

@zhouzh1
Copy link
Copy Markdown
Author

zhouzh1 commented Jun 4, 2025

@palpatim @lawmicha Could you help take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants