Skip to content

Conversation

yaroluchko
Copy link
Contributor

@yaroluchko yaroluchko commented Aug 14, 2024

Description of changes:

Documentation for customers to use Amplify Swift's shared keychain

Related GitHub issue #, if available:

N/A

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josefaidt josefaidt self-assigned this Aug 15, 2024
@josefaidt
Copy link
Contributor

Hey @yaroluchko left a comment to remove a stray space but overall changes look good to me!

@harsh62 harsh62 marked this pull request as ready for review March 19, 2025 17:53
@harsh62 harsh62 requested a review from josefaidt March 19, 2025 17:53
@harsh62 harsh62 added amplify/ios Mostly related to iOS software. and removed do-not-merge labels Mar 19, 2025
@harsh62 harsh62 requested a review from josefaidt March 19, 2025 18:36
@josefaidt josefaidt merged commit dc9b5e4 into main Mar 19, 2025
12 checks passed
@josefaidt josefaidt deleted the feat/swift-shared-keychain branch March 19, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/ios Mostly related to iOS software.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants