Skip to content

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Oct 18, 2024

Description of changes:

The PR updates the callout regarding support for visionOS.

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 marked this pull request as ready for review October 21, 2024 13:31
@harsh62 harsh62 requested a review from a team as a code owner October 21, 2024 13:31
sebaland
sebaland previously approved these changes Oct 21, 2024
Copy link
Contributor

@sebaland sebaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Just a couple of comments:

hdworld11
hdworld11 previously approved these changes Oct 21, 2024
@harsh62 harsh62 dismissed stale reviews from hdworld11 and sebaland via 23a8ee0 October 21, 2024 17:03
sebaland
sebaland previously approved these changes Oct 21, 2024
@harsh62 harsh62 enabled auto-merge (squash) October 22, 2024 14:49
@harsh62 harsh62 merged commit 2aeabe7 into main Oct 31, 2024
12 checks passed
@harsh62 harsh62 deleted the visionOS-support-update branch October 31, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants