Skip to content

Conversation

iartemiev
Copy link
Member

Description of changes:

Adds AppSync Events client docs

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev requested review from aspittel, swaminator and a team as code owners October 30, 2024 16:50
@iartemiev iartemiev force-pushed the events branch 4 times, most recently from 024c59d to 88a484c Compare October 30, 2024 16:57
@iartemiev iartemiev enabled auto-merge (squash) October 30, 2024 17:03
josefaidt
josefaidt previously approved these changes Oct 30, 2024
Copy link
Contributor

@swaminator swaminator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language changes requested

import { getCustomStaticPath } from '@/utils/getCustomStaticPath';

export const meta = {
title: 'Connect to AWS AppSync Events',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this title: "Real time events"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a separate page with that verbiage https://docs.amplify.aws/react/build-a-backend/data/subscribe-data/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Pub/Sub events?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that conflicts with the pub/sub category we'll be deprecating - https://docs.amplify.aws/gen1/javascript/build-a-backend/more-features/pubsub/

@iartemiev iartemiev merged commit aaca1ad into main Oct 30, 2024
12 checks passed
@iartemiev iartemiev deleted the events branch October 30, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants