Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/MDXComponents/MDXCode.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ const addVersions = (code: string) => {
/ANDROID_AUTHENTICATOR_VERSION/g,
versions.ANDROID_AUTHENTICATOR_VERSION
);
code = code.replace(
/ANDROID_APPSYNC_SDK_VERSION/g,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we choose a different value for this variable, it is too similar to the AppSync SDK for Android.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS AppSync SDK for Android is not on this docs site. I'd be hesitant to name this any different, as its not all events specific.

versions.ANDROID_APPSYNC_SDK_VERSION
);
return code;
};

Expand Down
3 changes: 2 additions & 1 deletion src/constants/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ export const versions = {
ANDROID_V1_KOTLIN_VERSION: '0.22.8',
ANDROID_SDK_VERSION: '2.76.0',
KOTLIN_SDK_VERSION: '1.3.31',
ANDROID_AUTHENTICATOR_VERSION: '1.4.0'
ANDROID_AUTHENTICATOR_VERSION: '1.4.0',
ANDROID_APPSYNC_SDK_VERSION: '1.0.0'
};
Loading