This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Allow out-of-band tags for stackset to remain during updates#127
Open
ksamyak-aws wants to merge 5 commits intoaws-cloudformation:masterfrom
Open
Allow out-of-band tags for stackset to remain during updates#127ksamyak-aws wants to merge 5 commits intoaws-cloudformation:masterfrom
ksamyak-aws wants to merge 5 commits intoaws-cloudformation:masterfrom
Conversation
patinti
approved these changes
Aug 19, 2025
aradven
suggested changes
Aug 19, 2025
Comment on lines
118
to
124
| Set<Tag> allTags = new HashSet<>(currentTags); | ||
| Set<Tag> currentTagSet = translateToSdkTags(tags); | ||
| allTags.addAll(currentTagSet); | ||
| // Remove the one's that were in the previousTags but not in tags | ||
| Set<Tag> previousTagSet = translateToSdkTags(previousTags); | ||
| previousTagSet.removeAll(currentTagSet); | ||
| allTags.removeAll(previousTagSet); |
There was a problem hiding this comment.
This is a little hard to follow, a lot of stuff being added/removed. Do we not just need to set the tags to targetTags + out of band tags? So something like:
outOfBandTags = currentTags - previousTags
tagsToSet = targetTags + outOfBandTags
aradven
approved these changes
Aug 19, 2025
patinti
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Allows out of band tags to remain during update stack set when performed by the resource provider. This makes it so the tags on the stackset resource itself are not overridden.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.