This repository was archived by the owner on Oct 23, 2025. It is now read-only.
Tags support added for cluster subnet group#187
Open
pmugdhamz wants to merge 3 commits intoaws-cloudformation:masterfrom
Open
Tags support added for cluster subnet group#187pmugdhamz wants to merge 3 commits intoaws-cloudformation:masterfrom
pmugdhamz wants to merge 3 commits intoaws-cloudformation:masterfrom
Conversation
adityatomer
reviewed
Jun 3, 2025
There was a problem hiding this comment.
Let's get rid of these SAM files, if not needed.
adityatomer
reviewed
Jun 3, 2025
| MAX_SUBNET_GROUP_NAME_LENGTH).toLowerCase()); | ||
| } | ||
|
|
||
| // Resource level + stack level tags |
There was a problem hiding this comment.
Missing system tags. All 3 - resource, system, stack tags are required to be merged.
adityatomer
reviewed
Jun 3, 2025
| desiredResourceState.getClusterSubnetGroupName()); | ||
|
|
||
| // Handle tags | ||
| Map<String, String> allDesiredTags = new HashMap<>(); |
adityatomer
reviewed
Jun 3, 2025
| return ProgressEvent.progress(desiredResourceState, callbackContext) | ||
| // Read current tags | ||
| .then(progress -> proxy.initiate(String.format("%s::Update::ReadTags", CALL_GRAPH_TYPE_NAME), proxyClient, progress.getResourceModel(), progress.getCallbackContext()) | ||
| .translateToServiceRequest(rm -> Translator.translateToReadTagsRequest(resourceName)) |
There was a problem hiding this comment.
this call is not required. We don't need to read live tags in update. Instead read tags using CFN request request.getPreviousResource .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Motivation]:
As part of the new initiative to support RBAC policies using Tags every resource on CFN need to support tags and should throw the appropriate errors in case of permission issues with creating/updating tags. This CR provides the use of tags for cluster subnet group API
[Testing]:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.