Fix E3009 false positive for Fn::Transform in additional properties#4368
Open
kddejong wants to merge 1 commit intoaws-cloudformation:mainfrom
Open
Fix E3009 false positive for Fn::Transform in additional properties#4368kddejong wants to merge 1 commit intoaws-cloudformation:mainfrom
kddejong wants to merge 1 commit intoaws-cloudformation:mainfrom
Conversation
Exclude Fn::Transform from additional properties validation when it's in the validator's context functions list. This allows Fn::Transform to be used in CloudFormation Init metadata and other contexts where CloudFormation supports it. Fixes aws-cloudformation#4363
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4368 +/- ##
==========================================
- Coverage 93.54% 93.52% -0.02%
==========================================
Files 418 418
Lines 14145 14148 +3
Branches 2817 2818 +1
==========================================
Hits 13232 13232
- Misses 567 568 +1
- Partials 346 348 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude Fn::Transform from additional properties validation when it's in the validator's context functions list. This allows Fn::Transform to be used in CloudFormation Init metadata and other contexts where CloudFormation supports it.
Fixes #4363
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.